Android: Minor activity lifecycle stuff #18230
Conversation
hrydgard
changed the title
hrydgard
changed the title
… switches in the log.
android/jni/app-android.cpp
Outdated
| @@ -688,8 +688,9 @@ extern "C" void Java_org_ppsspp_ppsspp_NativeApp_init | |||
| EARLY_LOG("NativeApp.init() -- begin"); | |||
| PROFILE_INIT(); | |||
|
|
|||
| std::lock_guard<std::mutex> guard(renderLock); // Note: This is held for the rest of this function - intended? | |||
| std::lock_guard<std::mutex> guard(renderLock); // Note: This is held for the rest of this function - intended? and even necessary? | |||
There was a problem hiding this comment.
I would think so. I think it should be on shutdown too. It should not be possible to update renderer_inited to true, update renderer_inited to false, or render at the same time. Those operations should all be sequenced. Remember that there are annoying things happening with resize events and etc.
-[Unknown]
There was a problem hiding this comment.
Yeah, true. I'll throw in a lock in shutdown too.
| if (!paused) { | ||
| activity.notifySurface(holder.getSurface()); | ||
| } else { | ||
| Log.i(TAG, "Skipping notifySurface while paused"); |
There was a problem hiding this comment.
This can't cause it to have an outdated surface, can it?
-[Unknown]
There was a problem hiding this comment.
It does appear to be OK because we always get a surface notification after the next resume, which is when we want it.
I believe spurious surfaceChanged events after pause are a bug that seems to have been fixed around Android 12.
|
Tested this on a whole bunch of devices and it behaves well. Even before this though, I wasn't really able to reproduce the app-not-responding reports I see in the logs from Google Play... |
Tried to keep the changes very safe, while still potentially fixing some minor things. Tests fine.
My goal is to see if we can fix some common ANRs. (application not responding).